Skip to content

BUG: Fix the particle conversion in MAD-NG#780

Open
jgray-19 wants to merge 1 commit into
xsuite:mainfrom
jgray-19:fix_ng_beam
Open

BUG: Fix the particle conversion in MAD-NG#780
jgray-19 wants to merge 1 commit into
xsuite:mainfrom
jgray-19:fix_ng_beam

Conversation

@jgray-19
Copy link
Copy Markdown
Contributor

Description

Please double check this, but I was was finding the particle pc was 1e18 too high for a specific test. I assumed the mass was in eV based on the documentation.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

Copy link
Copy Markdown
Collaborator

@szymonlopaciuk szymonlopaciuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, certainly this is a bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants