Update reqwest#425
Conversation
| [package] | ||
| name = "gcloud-artifact-registry" | ||
| version = "1.4.0" | ||
| version = "2.0.0" |
There was a problem hiding this comment.
Could you change the version to 1.5.0? We reserve major version bumps for significant breaking changes. For updates to interfaces or features, we use minor version increments. The same applies to the other crates as well.
There was a problem hiding this comment.
Changed to version 1.5.0.
|
|
||
| [features] | ||
| default = ["default-tls", "auth", "jwt-aws-lc-rs"] | ||
| default-tls = ["google-cloud-auth?/default-tls"] |
There was a problem hiding this comment.
The CI specifies features, but since it uses the workflow from the main branch, we need to split the feature changes into two steps.
Could you rename rustls to rustls-tls and set default-tls to be the same as rustls-tls? After merging, I will handle the CI updates and the final feature renaming on my end.
There was a problem hiding this comment.
Renamed to rustls-tls, thanks.
There was a problem hiding this comment.
default-tls feature is still required to pass CI. Could you add the default-tls feature for each create .
default-tls = ["google-cloud-auth?/default-tls"]
|
@yoshidan thank you for review, i've applied your feedback. |
2 participants
Starting from reqwest 1.3, the default TLS became rustls, and aws-lc is used as the crypto provider.
I updated reqwest and adjusted the features to match reqwest 1.3.
This change is breaking, so I bumped the major version too.
I do not fully understand all the complex TLS related dependencies, so please tell me if anything is wrong.
Storage uses ring internally. Do we also need to align this with the crypto provider used by reqwest and jsonwebtoken?