-
Notifications
You must be signed in to change notification settings - Fork 2
Clone of 390 2 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
illicitonion
wants to merge
5
commits into
main
Choose a base branch
from
clone-of-390-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
949f78b
chore: add .venv to .gitignore
jakr-s 95f3415
task(cat): convert JS code to python
jakr-s 63ca183
task(ls): convert JS code to python
jakr-s 2dc442d
task(wc): convert JS code to python
jakr-s 2c580ce
refactor: add type hints to functions
jakr-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| node_modules | ||
| .venv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import argparse | ||
| import sys | ||
|
|
||
|
|
||
| def parse_args(): | ||
| parser = argparse.ArgumentParser( | ||
| description="Reads file(s) and writes them to the standard output", | ||
| ) | ||
| parser.add_argument("paths", nargs="+", help="The file path(s) to process") | ||
| parser.add_argument( | ||
| "-n", | ||
| action="store_true", | ||
| dest="number_all", | ||
| help="Number the output lines, starting at 1.", | ||
| ) | ||
| parser.add_argument( | ||
| "-b", | ||
| action="store_true", | ||
| dest="number_nonblank", | ||
| help="Number only non-blank output lines, starting at 1.", | ||
| ) | ||
| return parser.parse_args() | ||
|
|
||
|
|
||
| def main(): | ||
| args = parse_args() | ||
|
|
||
| try: | ||
| for path in args.paths: | ||
| line_num = 1 | ||
|
|
||
| with open(path, "r", encoding="utf-8") as file: | ||
| for raw_line in file: | ||
| line = raw_line.rstrip("\n") | ||
| is_blank = line.strip() == "" | ||
| should_number = args.number_all or ( | ||
| args.number_nonblank and not is_blank) | ||
|
|
||
| if should_number: | ||
| print(f"{line_num} {line}") | ||
| line_num += 1 | ||
| else: | ||
| print(line) | ||
| except OSError as err: | ||
| print(err, file=sys.stderr) | ||
|
|
||
| return 0 | ||
|
|
||
|
|
||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| import argparse | ||
| import os | ||
| import stat | ||
| import sys | ||
|
|
||
|
|
||
| def parse_args(): | ||
| parser = argparse.ArgumentParser( | ||
| description="List directory contents", | ||
| ) | ||
| parser.add_argument( | ||
| "paths", | ||
| nargs="*", | ||
| help="The file path to process (defaults to current directory)", | ||
| ) | ||
| parser.add_argument( | ||
| "-a", | ||
| action="store_true", | ||
| dest="include_hidden", | ||
| help="Include directory entries whose names begin with a dot ('.').", | ||
| ) | ||
| parser.add_argument( | ||
| "-1", | ||
| action="store_true", | ||
| dest="one_per_line", | ||
| help="Force output to be one entry per line.", | ||
| ) | ||
| return parser.parse_args() | ||
|
|
||
|
|
||
| def filter_hidden(files: list[str]) -> list[str]: | ||
| return [name for name in files if not name.startswith(".")] | ||
|
|
||
|
|
||
| def get_visible_entries(files: list[str], include_hidden: bool): | ||
| return files if include_hidden else filter_hidden(files) | ||
|
|
||
|
|
||
| def format_entries(files: list[str], one_per_line: bool): | ||
| if len(files) == 0: | ||
| return | ||
| print(("\n" if one_per_line else "\t").join(files)) | ||
|
|
||
|
|
||
| def main(): | ||
| args = parse_args() | ||
|
|
||
| try: | ||
| file_paths = args.paths if args.paths else ["."] | ||
| include_hidden = bool(args.include_hidden) | ||
| one_per_line = bool(args.one_per_line) | ||
|
|
||
| result_files: list[str] = [] | ||
| result_dirs: dict[str, list[str]] = {} | ||
|
|
||
| for file_path in file_paths: | ||
| st = os.stat(file_path) | ||
| # Is a file? | ||
| if stat.S_ISREG(st.st_mode): | ||
| result_files.append(file_path) | ||
| # Is a directory? | ||
| if stat.S_ISDIR(st.st_mode): | ||
| result_dirs[file_path] = os.listdir(file_path) | ||
|
|
||
| result_files = get_visible_entries(result_files, include_hidden) | ||
|
|
||
| if len(file_paths) == 1: | ||
| entries = list(result_files) | ||
| for contents in result_dirs.values(): | ||
| filtered = get_visible_entries(contents, include_hidden) | ||
| entries.extend(filtered) | ||
| format_entries(entries, one_per_line) | ||
| else: | ||
| format_entries(result_files, one_per_line) | ||
|
|
||
| for directory, contents in result_dirs.items(): | ||
| print("\n" + directory + ":") | ||
| filtered = get_visible_entries(contents, include_hidden) | ||
| format_entries(filtered, one_per_line) | ||
| except OSError as err: | ||
| print(str(err), file=sys.stderr) | ||
|
|
||
| return 0 | ||
|
|
||
|
|
||
| main() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| tabulate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| import argparse | ||
| import os | ||
| import sys | ||
|
|
||
| from tabulate import tabulate | ||
|
|
||
|
|
||
| def parse_args(): | ||
| parser = argparse.ArgumentParser( | ||
| description="word, line and byte count", | ||
| ) | ||
| parser.add_argument("paths", nargs="+", | ||
| help="The file path(s) to process.") | ||
| parser.add_argument( | ||
| "-l", | ||
| "--lines", | ||
| action="store_true", | ||
| help="The number of lines in each input file is written to the standard output.", | ||
| ) | ||
| parser.add_argument( | ||
| "-w", | ||
| "--words", | ||
| action="store_true", | ||
| help="The number of words in each input file is written to the standard output.", | ||
| ) | ||
| parser.add_argument( | ||
| "-c", | ||
| "--bytes", | ||
| action="store_true", | ||
| dest="bytes", | ||
| help="The number of bytes in each input file is written to the standard output.", | ||
| ) | ||
| return parser.parse_args() | ||
|
|
||
|
|
||
| def main(): | ||
| args = parse_args() | ||
|
|
||
| try: | ||
| file_paths: list[str] = args.paths | ||
| results: dict[str, dict[str, int]] = {} | ||
|
|
||
| for file_path in file_paths: | ||
| stats = os.stat(file_path) | ||
| count = {"lines": 0, "words": 0, "bytes": stats.st_size} | ||
|
|
||
| with open(file_path, "r", encoding="utf-8") as file: | ||
| for line in file: | ||
| count["lines"] += 1 | ||
| trimmed = line.strip() | ||
| if len(trimmed) > 0: | ||
| count["words"] += len(trimmed.split()) | ||
|
|
||
| results[file_path] = count | ||
|
|
||
| if len(file_paths) > 1: | ||
| total = {"lines": 0, "words": 0, "bytes": 0} | ||
| for file_count in results.values(): | ||
| total["lines"] += file_count["lines"] | ||
| total["words"] += file_count["words"] | ||
| total["bytes"] += file_count["bytes"] | ||
| results["total"] = total | ||
|
|
||
| no_options_provided = not (args.lines or args.words or args.bytes) | ||
| selected_option_keys: list[str] = [] | ||
|
|
||
| if args.lines: | ||
| selected_option_keys.append("lines") | ||
| if args.words: | ||
| selected_option_keys.append("words") | ||
| if args.bytes: | ||
| selected_option_keys.append("bytes") | ||
|
|
||
| output_columns = [ | ||
| "lines", "words", "bytes"] if no_options_provided else selected_option_keys | ||
| rows: list[list[str | int]] = [] | ||
| for name, values in results.items(): | ||
| rows.append([name] + [values[column] for column in output_columns]) | ||
|
|
||
| if no_options_provided: | ||
| print(tabulate(rows, headers=[ | ||
| "index"] + output_columns)) | ||
| else: | ||
| print(tabulate(rows, headers=[ | ||
| "index"] + output_columns)) | ||
| except OSError as err: | ||
| print(str(err), file=sys.stderr) | ||
|
|
||
| return 0 | ||
|
|
||
|
|
||
| main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments '# Is a file?' and '# Is a directory?' are describing what the following if-statements are checking. Since the code is already using clear function names (stat.S_ISREG and stat.S_ISDIR) and variable names, these comments may not add much value. When code is self-explanatory, do you think it's necessary to add comments that just restate what the code does? How might you decide when a comment is truly helpful versus when it might be redundant?