Make checkboxes not use interior mutability#2976
Merged
Conversation
Member
Author
tested grid overlay checkbox in desktop |
Keavon
requested changes
Aug 2, 2025
timon-schelling
force-pushed
the
make-checkboxes-not-use-interior-mutability
branch
from
a032521 to
d9d1164
Compare
timon-schelling
force-pushed
the
make-checkboxes-not-use-interior-mutability
branch
from
d9d1164 to
e81776d
Compare
timon-schelling
force-pushed
the
make-checkboxes-not-use-interior-mutability
branch
from
e81776d to
a478d83
Compare
Member
Author
|
@Keavon, Sorry I misunderstood what the interior mutability of CheckboxId was used for and tested the wrong thing. I think I tested the correct thing now, clicking a label now toggles the associated Checkbox. Serialization of CheckboxId is still working as expected, this PR still makes Chechboxes work on desktop. 2025-08-03.14-00-19.mp4 |
Keavon
force-pushed
the
make-checkboxes-not-use-interior-mutability
branch
from
ad46341 to
dd6f28a
Compare
Keavon
approved these changes
Aug 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2974