Skip to content

Desktop: Add fullscreen window mode#3625

Merged
timon-schelling merged 23 commits intomasterfrom
desktop-f11-for-fullscreen
Jan 19, 2026
Merged

Desktop: Add fullscreen window mode#3625
timon-schelling merged 23 commits intomasterfrom
desktop-f11-for-fullscreen

Conversation

@timon-schelling
Copy link
Copy Markdown
Member

@timon-schelling timon-schelling commented Jan 12, 2026

f11 is not usable on mac for this, browsers use cmd + strg + f.
now opted for cmd + strg + f on mac.

Closes #3510

#3656 Should be merged right after this to fix
#3625 (comment)

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 12, 2026 00:08 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 13, 2026 15:43 Inactive
@timon-schelling timon-schelling changed the title Desktop: F11 for fullscreen Desktop: Add Fullscreen Shortcut Jan 13, 2026
@timon-schelling timon-schelling marked this pull request as ready for review January 13, 2026 15:57
@timon-schelling timon-schelling force-pushed the desktop-f11-for-fullscreen branch from f08bd09 to f7fa350 Compare January 13, 2026 15:57
@timon-schelling
Copy link
Copy Markdown
Member Author

@Keavon I don't think you need to do a full review. Desktop changes are really strait forward. But a opinion on macro changes would be helpful.

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 13, 2026 16:01 Inactive
@timon-schelling timon-schelling force-pushed the desktop-f11-for-fullscreen branch from f7fa350 to af6a308 Compare January 14, 2026 00:56
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 14, 2026 00:59 Inactive
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Jan 15, 2026

  • When hitting F11 after being in fullscreen, we get an inset window:
image
  • The title bar should show the Exit Fullscreen button in place of Minimize/Maximize/Close when fullscreen
  • Replace the input macro's new attribute named active with its inverse named disabled
  • Clean up the input macro by replacing its patching logic used for scroll preferences with disabled

@timon-schelling timon-schelling marked this pull request as draft January 15, 2026 02:14
@Keavon Keavon changed the title Desktop: Add Fullscreen Shortcut Desktop: Add a fullscreen window mode Jan 15, 2026
@timon-schelling timon-schelling force-pushed the desktop-f11-for-fullscreen branch 2 times, most recently from 31e4c43 to d7cef15 Compare January 15, 2026 13:08
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 13:10 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 13:23 Inactive
@timon-schelling timon-schelling force-pushed the desktop-f11-for-fullscreen branch from d7cef15 to c6e70d9 Compare January 15, 2026 13:29
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 13:48 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 14:54 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 15:08 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 15:21 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 15:39 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 15:52 Inactive
@timon-schelling timon-schelling marked this pull request as ready for review January 15, 2026 15:54
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 15, 2026 16:04 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 16, 2026 00:40 Inactive
@Keavon Keavon changed the title Desktop: Add a fullscreen window mode Desktop: Add fullscreen window mode Jan 16, 2026
@timon-schelling timon-schelling force-pushed the desktop-f11-for-fullscreen branch from a84bb6a to a0c8e8d Compare January 16, 2026 10:22
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 16, 2026 10:25 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 16, 2026 10:30 Inactive
@Keavon Keavon force-pushed the desktop-f11-for-fullscreen branch from d2bc0fd to 482834f Compare January 19, 2026 02:09
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 19, 2026 15:28 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 19, 2026 16:03 Inactive
@timon-schelling timon-schelling merged commit 07fbcd4 into master Jan 19, 2026
3 checks passed
@timon-schelling timon-schelling deleted the desktop-f11-for-fullscreen branch January 19, 2026 16:32
jackfruitdog pushed a commit to jackfruitdog/Graphite that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop fullscreen mode with F11

2 participants