Replace globals with editor environment#3656
Merged
timon-schelling merged 29 commits intomasterfrom Jan 19, 2026
Merged
Conversation
Keavon
changed the title
Keavon
force-pushed
the
desktop-f11-for-fullscreen
branch
from
d2bc0fd to
482834f
Compare
Keavon
force-pushed
the
replace-globals
branch
from
24563a6 to
3060cd1
Compare
Member
|
Why does this still use interior mutability? I thought you wanted to make the globals message handler no longer use interior mutability and instead just pass it around. Is there a reason why it is necessary to do it like this? |
Member
|
Globals are still required by our trait impls, like |
Member
Author
|
*not required, but fixing that would include wrapping a bunch of structs and enums in wrappers that include the environment info just to be ale to impl display and similar std traits. In my opinion not worse it, but it ca be done, don't know if it would be cleaner though. |
TrueDoctor
reviewed
Jan 19, 2026
timon-schelling
force-pushed
the
replace-globals
branch
from
b4b72d6 to
724e106
Compare
jackfruitdog
pushed a commit
to jackfruitdog/Graphite
that referenced
this pull request
Jan 25, 2026
Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3625