Skip to content

Add "Loop Level" to the Position context reader node#3679

Merged
Keavon merged 2 commits intomasterfrom
position-loop-level
Jan 28, 2026
Merged

Add "Loop Level" to the Position context reader node#3679
Keavon merged 2 commits intomasterfrom
position-loop-level

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Jan 25, 2026

No description provided.

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 25, 2026 00:38 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from 53ad1d4 to a9ba88a Compare January 26, 2026 00:54
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 00:59 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from a9ba88a to 945e8e8 Compare January 26, 2026 05:21
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 05:25 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from 945e8e8 to c4ae3a5 Compare January 26, 2026 06:04
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 06:08 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from c4ae3a5 to fd02938 Compare January 26, 2026 06:52
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 06:56 Inactive
@Keavon Keavon requested a review from TrueDoctor January 26, 2026 07:24
@Keavon Keavon force-pushed the position-loop-level branch from fd02938 to 0881757 Compare January 26, 2026 08:43
Copy link
Copy Markdown
Member

@TrueDoctor TrueDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks caching with multiple loop levels:

Image

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 12:33 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from e44c102 to 11e9f72 Compare January 26, 2026 17:43
@Keavon Keavon requested a review from TrueDoctor January 26, 2026 17:44
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 17:48 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from 11e9f72 to 6228ac9 Compare January 26, 2026 21:51
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 26, 2026 21:56 Inactive
@Keavon Keavon force-pushed the position-loop-level branch from 6228ac9 to 5e8f9c2 Compare January 28, 2026 04:28
@Keavon Keavon enabled auto-merge (squash) January 28, 2026 04:28
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) January 28, 2026 10:38 Inactive
@Keavon Keavon merged commit 3900048 into master Jan 28, 2026
4 checks passed
@Keavon Keavon deleted the position-loop-level branch January 28, 2026 10:52
@TrueDoctor
Copy link
Copy Markdown
Member

This broke the pointer position node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants