Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions infrastructure/stacks/api-layer/cloudwatch.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,17 @@ resource "aws_cloudwatch_log_group" "firehose_audit" {
Name = "kinesis-firehose-logs"
Stack = local.stack_name
}

depends_on = [
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too early in the morning for me to work out the dependency graph in my head, but we can see if Terraform is happy with this and that there are no circular dependencies. I think my main worry is that the firehose modules take in a log group name...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've not already run a terraform plan, then worth doing so! If you have and no issue, then happy to approve!

module.eligibility_audit_firehose_delivery_stream.kinesis_firehose_cmk_arn
]
}

resource "aws_cloudwatch_log_stream" "firehose_audit_stream" {
name = "audit_stream_log"
log_group_name = aws_cloudwatch_log_group.firehose_audit.name

depends_on = [
aws_cloudwatch_log_group.firehose_audit
]
}