infra: add firehose resource dependency for firehose cloudwatch logs#412
Merged
Karthikeyannhs merged 5 commits intomainfrom Oct 7, 2025
Merged
infra: add firehose resource dependency for firehose cloudwatch logs#412Karthikeyannhs merged 5 commits intomainfrom
Karthikeyannhs merged 5 commits intomainfrom
Conversation
robbailiff2
approved these changes
Oct 3, 2025
eddalmond1
reviewed
Oct 3, 2025
| Stack = local.stack_name | ||
| } | ||
|
|
||
| depends_on = [ |
Collaborator
There was a problem hiding this comment.
too early in the morning for me to work out the dependency graph in my head, but we can see if Terraform is happy with this and that there are no circular dependencies. I think my main worry is that the firehose modules take in a log group name...
Collaborator
There was a problem hiding this comment.
If you've not already run a terraform plan, then worth doing so! If you have and no issue, then happy to approve!
eddalmond1
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.