-
Notifications
You must be signed in to change notification settings - Fork 3
infra: add firehose resource dependency for firehose cloudwatch logs #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
db8c351
infra: add firehose resource dependency for firehose cloudwatch logs
Karthikeyannhs eb47600
infra: add firehose resource dependency for firehose cloudwatch logs
Karthikeyannhs 9394597
Merge remote-tracking branch 'origin/main' into fix/eli-463/firehose-…
Karthikeyannhs e27f599
fix cycle dependency
Karthikeyannhs d060c64
Merge branch 'main' into fix/eli-463/firehose-forwarder
Karthikeyannhs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too early in the morning for me to work out the dependency graph in my head, but we can see if Terraform is happy with this and that there are no circular dependencies. I think my main worry is that the firehose modules take in a log group name...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've not already run a terraform plan, then worth doing so! If you have and no issue, then happy to approve!