Conversation
cfs-data
reviewed
Mar 10, 2026
| lowpass_cutoff: float | None = 5.0e-6 | ||
| highpass_regression_order: int = 2 | ||
| lowpass_regression_order: int = 0 | ||
| mask_data: UploadFile = File() |
Collaborator
There was a problem hiding this comment.
Since the mask should fit in memory, use bytes here as typing instead of UploadFile to avoid the file system spooling in starlette
Collaborator
There was a problem hiding this comment.
(also in the other places)
Collaborator
Author
There was a problem hiding this comment.
yhea i changed it so it follows more the repo of my old project. (and it works till now) later if we fixed the last issue we can trim one for one till it bytes again i think
a83ea9e to
fac38a5
Compare
fac38a5 to
e59c8ba
Compare
cadd6d0 to
7da89b3
Compare
7da89b3 to
79eb184
Compare
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC of how to multipart requests, team up with @cfs-data
what i have learned so far:
Form()in the input as pydantic model, and theFileUpload/File()in the same pydantic model looks like resolving the openAPI render issue. (see image) this will put it as parameters as aForm(). so far looking good.to investigate
bytesalso instead ofUploadFileValue error, chamber impression mark is not a striation mark [type=value_error, input_value=<MarkType.CHAMBER_IMPRESS...hamber impression mark'>, input_type=MarkType]` -> split it up with 2 different enums to make it explicit what to use in endpoint.
the other stuff works
what to do:
Marktypeto different typesbounding_box_listschema defaults