Allow V2 reader to read v1 manifests#1634
Merged
Merged
Conversation
emkornfield
changed the title
Contributor
Author
|
@Fokko I think this fixes the issue as described, mind taking a look? I think CI failures might be unrelated? |
Contributor
|
@emkornfield Thanks for working on this 🙌 Let me take a look. The CI is unrelated indeed, and has been fixed on main. |
Contributor
|
I've did some end to end validation, and it fixed the issue on the PyIceberg side 👍 |
Fokko
approved these changes
Sep 1, 2025
Contributor
|
Thanks @emkornfield 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a proposed change allow for reading V1 manifests with a V2 reader.
It is currently broken, I suspect Avro might not be doing resolution based on field ID but I need to dig further.
What changes are included in this PR?
Are these changes tested?
It appears there was an existing test that was meant to cover this feature but it in fact had a bug where it was just checking v2 round-trip. I updated the test as well.