Skip to content

Allow V2 reader to read v1 manifests #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 4 commits into from
Sep 1, 2025
Merged

Allow V2 reader to read v1 manifests #1634

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fbb260
[WIP] Allow V2 reader to read v1 manifests
emkornfield Aug 28, 2025
4b109f3
defaults belong in serde
emkornfield Aug 29, 2025
f470eeb
remove whitespace
emkornfield Aug 29, 2025
82162a0
Merge branch 'main' into stack/v2_reader
Fokko Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion crates/iceberg/src/spec/manifest_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,8 +796,11 @@ pub(super) mod _serde {
pub manifest_path: String,
pub manifest_length: i64,
pub partition_spec_id: i32,
#[serde(default = "v2_default_content_for_v1")]
pub content: i32,
#[serde(default = "v2_default_sequence_number_for_v1")]
pub sequence_number: i64,
#[serde(default = "v2_default_min_sequence_number_for_v1")]
pub min_sequence_number: i64,
pub added_snapshot_id: i64,
#[serde(alias = "added_data_files_count", alias = "added_files_count")]
Expand Down Expand Up @@ -836,6 +839,18 @@ pub(super) mod _serde {
}
}

fn v2_default_content_for_v1() -> i32 {
super::ManifestContentType::Data as i32
}

fn v2_default_sequence_number_for_v1() -> i64 {
0
}

fn v2_default_min_sequence_number_for_v1() -> i64 {
0
}

impl ManifestFileV1 {
/// Converts the [ManifestFileV1] into a [ManifestFile].
pub fn try_into(self) -> Result<ManifestFile> {
Expand Down Expand Up @@ -1304,7 +1319,7 @@ mod test {
let io = FileIOBuilder::new_fs_io().build().unwrap();
let output_file = io.new_output(path.to_str().unwrap()).unwrap();

let mut writer = ManifestListWriter::v2(output_file, 1646658105718557341, Some(0), 1);
let mut writer = ManifestListWriter::v1(output_file, 1646658105718557341, Some(0));
writer
.add_manifests(expected_manifest_list.entries.clone().into_iter())
.unwrap();
Expand Down
Loading