refactor: reduce PHPStan child return type baseline#10165
Open
memleakd wants to merge 1 commit intocodeigniter4:developfrom
Open
refactor: reduce PHPStan child return type baseline#10165memleakd wants to merge 1 commit intocodeigniter4:developfrom
memleakd wants to merge 1 commit intocodeigniter4:developfrom
Conversation
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
98eaf51 to
90a6036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refines PHPDoc return types so they are covariant with parent/interface contracts and better match the current implementations.
This reduces
method.childReturnTypePHPStan baseline entries from 28 to 2. The remaining entries areUploadedFile::move()andOutgoingRequest::getUri(), which are real API contract conflicts and should be handled separately.Related to #6310.
Verification:
composer phpstan:checkgit diff --checkChecklist: