Skip to content

Color picker#302

Merged
hakalb merged 3 commits intomainfrom
cod-312
Apr 13, 2025
Merged

Color picker#302
hakalb merged 3 commits intomainfrom
cod-312

Conversation

@hakalb
Copy link
Copy Markdown
Member

@hakalb hakalb commented Apr 11, 2025

closes cod-312, cod-314, cod-315

@hakalb hakalb self-assigned this Apr 11, 2025
Copilot AI review requested due to automatic review settings April 11, 2025 20:51
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

libs/shared/ui/react-components/src/lib/icon/IconPicker.tsx:146

  • The change from using an arrow function to passing setOpen directly may affect the callback signature expected by the Dialog component. Please ensure that setOpen receives the correct value (likely a boolean) and that this change does not introduce unintended behavior.
<Dialog open={open} onOpenChange={setOpen}>

libs/app-cms/feature/seed/src/lib/utils/temp-store.ts:37

  • [nitpick] Using JSON.stringify for map keys can work but may lead to issues if key ordering is not stable. Consider documenting the expected structure or using a serialization method that guarantees key order for consistency.
mapper.category.set(JSON.stringify(category), categoryId);

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 11, 2025

View your CI Pipeline Execution ↗ for commit 091e877.

Command Status Duration Result
nx-cloud record -- nx format:check ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-13 19:58:30 UTC

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-302 https://cdwr-cms-pr-302.fly.dev
web cdwr-web-pr-302 https://cdwr-web-pr-302.fly.dev

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (535ce32) to head (091e877).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   81.09%   81.08%   -0.02%     
==========================================
  Files          63       63              
  Lines        1074     1073       -1     
  Branches      216      216              
==========================================
- Hits          871      870       -1     
  Misses        203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-302 https://cdwr-cms-pr-302.fly.dev
web cdwr-web-pr-302 https://cdwr-web-pr-302.fly.dev

@hakalb hakalb enabled auto-merge April 13, 2025 19:45
@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-302 https://cdwr-cms-pr-302.fly.dev
web cdwr-web-pr-302 https://cdwr-web-pr-302.fly.dev

@hakalb hakalb added this pull request to the merge queue Apr 13, 2025
Merged via the queue into main with commit 68431ed Apr 13, 2025
17 checks passed
@hakalb hakalb deleted the cod-312 branch April 13, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants