Conversation
closed COD-312
|
|
There was a problem hiding this comment.
Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
libs/shared/ui/react-components/src/lib/icon/IconPicker.tsx:146
- The change from using an arrow function to passing setOpen directly may affect the callback signature expected by the Dialog component. Please ensure that setOpen receives the correct value (likely a boolean) and that this change does not introduce unintended behavior.
<Dialog open={open} onOpenChange={setOpen}>
libs/app-cms/feature/seed/src/lib/utils/temp-store.ts:37
- [nitpick] Using JSON.stringify for map keys can work but may lead to issues if key ordering is not stable. Consider documenting the expected structure or using a serialization method that guarantees key order for consistency.
mapper.category.set(JSON.stringify(category), categoryId);
|
View your CI Pipeline Execution ↗ for commit 091e877.
☁️ Nx Cloud last updated this comment at |
|
✨ Your pull request projects are ready for preview
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 81.09% 81.08% -0.02%
==========================================
Files 63 63
Lines 1074 1073 -1
Branches 216 216
==========================================
- Hits 871 870 -1
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
closed COD-314
|
✨ Your pull request projects are ready for preview
|
|
✨ Your pull request projects are ready for preview
|
closes cod-312, cod-314, cod-315