spregistry: fix UnpackIntoInterface bug for getProvider*#16
Merged
Conversation
Calibnet repro:
abi: cannot unmarshal struct { ProviderId *big.Int ...; Info struct {...} }
in to *big.Int
go-ethereum's UnpackIntoInterface mishandles single-output tuples with
named subfields -- it tries to assign the entire decoded tuple struct
into the destination's first field (*big.Int), which fails. The bytes
themselves decode fine via abi.Unpack into an anonymous struct.
Switch GetProvider and GetProviderByAddress to abi.Unpack + json
round-trip into json-tagged result structs. Add a synthetic-payload
unit test that locks in the fix without needing live RPC.
Also runs gofmt over contract.go (pre-existing alignment drift).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calibnet repro:
abi: cannot unmarshal struct { ProviderId *big.Int ...; Info struct {...} }
in to *big.Int
go-ethereum's UnpackIntoInterface mishandles single-output tuples with named subfields -- it tries to assign the entire decoded tuple struct into the destination's first field (*big.Int), which fails. The bytes themselves decode fine via abi.Unpack into an anonymous struct.
Switch GetProvider and GetProviderByAddress to abi.Unpack + json round-trip into json-tagged result structs. Add a synthetic-payload unit test that locks in the fix without needing live RPC.
Also runs gofmt over contract.go (pre-existing alignment drift).