Conversation
…nimum version Changed the deephaven-server dependency constraint from `~=` (compatible release) to `>=` (minimum version) to allow more flexible version compatibility.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request changes the deephaven-server dependency constraint from compatible release (~=) to minimum version (>=) to support newer Deephaven versions.
Key Changes:
- Modified the version constraint operator for deephaven-server from
~=to>=in setup.py
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| python_requires=">=3.10", | ||
| install_requires=[ | ||
| f"deephaven-server~={dh_version}", | ||
| f"deephaven-server>={dh_version}", |
There was a problem hiding this comment.
The dhib_env.py script at line 616 parses dependency versions by removing "==" and "~=" operators, but it doesn't handle the ">=" operator that is now being used in setup.py. This will cause the parsing to fail or produce incorrect version strings when the release() function tries to extract the deephaven version from the wheel dependencies. The line should be updated to also handle the ">=" operator.
Suggested change
| f"deephaven-server>={dh_version}", | |
| f"deephaven-server=={dh_version}", |
Added support for parsing the `>=` operator when extracting the deephaven-server version from package dependencies, following the recent change from `~=` to `>=` in the dependency constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support newer Deephaven versions