Skip to content

feat: Support newer Deephaven versions #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chipkent merged 2 commits into from
Jan 8, 2026
Merged

feat: Support newer Deephaven versions #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2fa3b8
fix: Change deephaven-server dependency from compatible release to mi…
chipkent Jan 8, 2026
cabba17
fix: Handle >= operator in deephaven-server version parsing
chipkent Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dhib_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ def release(
wheel = download_wheel(python, "deephaven_ib", dh_ib_version)
deps = pkg_dependencies(wheel)
ib_version = deps["ibapi"].replace("==", "")
dh_version = deps["deephaven-server"].replace("==", "").replace("~=", "")
dh_version = deps["deephaven-server"].replace("==", "").replace("~=", "").replace(">=", "")

version_assert_format(dh_version)
version_assert_format(ib_version)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def version_assert_format(version: str, allow_zero_prefix: bool=False) -> None:
packages=setuptools.find_packages(where="src"),
python_requires=">=3.10",
install_requires=[
f"deephaven-server~={dh_version}",
f"deephaven-server>={dh_version}",
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dhib_env.py script at line 616 parses dependency versions by removing "==" and "~=" operators, but it doesn't handle the ">=" operator that is now being used in setup.py. This will cause the parsing to fail or produce incorrect version strings when the release() function tries to extract the deephaven version from the wheel dependencies. The line should be updated to also handle the ">=" operator.

Suggested change
f"deephaven-server>={dh_version}",
f"deephaven-server=={dh_version}",

Copilot uses AI. Check for mistakes.
Comment thread
chipkent marked this conversation as resolved.
"pandas",
f"ibapi=={ib_version}",
"lxml",
Expand Down
Loading