Onboarding Brand Design Update: Add in-context Main Network dialog#8480
Draft
Conversation
Contributor
Author
This was referenced May 7, 2026
Draft
cc16580 to
071b244
Compare
9ce56f5 to
abdc187
Compare
abdc187 to
d5674d7
Compare
071b244 to
64da96e
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 64da96e. Configure here.
d5674d7 to
b9a5cda
Compare
64da96e to
ec42745
Compare
ec42745 to
6e285f7
Compare
7d9b64a to
c23d1ca
Compare
6e285f7 to
e306f79
Compare
13 tasks
e306f79 to
d0d5650
Compare
c23d1ca to
6d41103
Compare
This was referenced May 11, 2026
6d41103 to
6909efc
Compare
d0d5650 to
3c09cc1
Compare
6909efc to
7079813
Compare
3c09cc1 to
538855a
Compare
Reuses bg_onboarding_trackers_blocked, the shared post-page-load banner.
7079813 to
3d6239a
Compare
538855a to
04e03bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1214598065379694?focus=true
Description
Migrates the Main Network contextual onboarding dialog to the new brand-design layout introduced in #8439, gated behind the
onboardingBrandDesignUpdatefeature flag.With the flag on:
DaxMainNetworkCta(pixel names,ctaPixelParam,ctaId, body-string composition) so the brand-design path stays telemetry-equivalent to legacy.Out of scope (still legacy / stub-only with the flag on, queued in follow-up PRs in this stack): no-trackers, fire-button, end. Their
Dax*BrandDesignUpdateContextualCtaclasses remain as scaffolding.Steps to test this PR
Designs
Please run all testing steps for in-context dialog changes from the contextual-end branch/PR to ease the testing burden.
To see these changes patch (Linear onboarding flag included just for continuity)
UI changes
Screenshots
Note
Medium Risk
Changes the in-context onboarding CTA selection and rendering for major-network detection (behind the brand-design flag), which could affect when dialogs appear and how pixels are fired. Risk is limited by feature gating and added tests, but impacts onboarding UX/telemetry.
Overview
Migrates the Main Network contextual onboarding dialog to the new brand-design in-context card when the brand-design update is enabled, while preserving the legacy
DaxMainNetworkCtapath when disabled.Implements
DaxMainNetworkBrandDesignUpdateContextualCtato actually render content (description text, primary CTA click handling, background banner) and to vary the body string based on whether the site domain matches known network domains.Adds tests to verify the brand-design CTA is returned for major networks and that dismissal/pixel behavior remains aligned (cta id/param and shown/ok/close pixels).
Reviewed by Cursor Bugbot for commit 04e03bc. Bugbot is set up for automated code reviews on this repo. Configure here.