Onboarding Brand Design Update: Add in-context End dialog

[mikescamell]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1214598047620091?focus=true

Description

Migrates the End contextual onboarding dialog ("You're all set!") to the new brand-design layout introduced in #8439, gated behind the onboardingBrandDesignUpdate feature flag — and closes out the in-context CTA migration started in this stack.

With the flag on:

• End CTA renders in the new card chrome with title and body as distinct blocks.
• End CTA wires up to its background banner — slides up from behind the card on appear, slides out on dismiss / content swap.
• Consolidates trackers/no-trackers/main-network when the End CTA arms — the three post-page-load CTAs converge cleanly into the End CTA hand-off so we don't double-fire / leave a stale background banner behind.
• Tightens DaxEndCta pixel param assertions in tests so the brand-design path stays telemetry-equivalent to legacy.

With this PR merged, all in-context dialogs (SERP, Trackers Blocked, No Trackers, Main Network, Fire Button, Site Suggestions, End) are migrated to the brand-design layout under onboardingBrandDesignUpdate. No legacy / stub paths remain on the brand-design code path.

Steps to test this PR

Designs

Please run all testing steps for in-context dialog changes — this PR is the canonical surface to test the full contextual flow end-to-end.

To see these changes patch (Linear onboarding flag included just for continuity)

Index: app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
--- a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt	(revision 6fd565c8894daba16281ae9bcf3452d038ae8d6d)
+++ b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt	(date 1777967047929)
@@ -34,13 +34,13 @@
      * Main toggle for the onboarding brand design update feature.
      * Default value: false (disabled).
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun self(): Toggle
 
     /**
      * Toggle for the brand design update variant.
      * Default value: false (disabled).
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun brandDesignUpdate(): Toggle
 }
Index: app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
--- a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt	(revision 6fd565c8894daba16281ae9bcf3452d038ae8d6d)
+++ b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt	(date 1777657893440)
@@ -45,7 +45,7 @@
     val viewState = _viewState.asStateFlow()
 
     fun initializePages() {
-        pageLayoutManager.buildPageBlueprints()
+        pageLayoutManager.buildBrandDesignUpdatePageBlueprints()
     }
 
     fun pageCount(): Int {
@@ -69,8 +69,8 @@
         }
     }
 
-    fun initializeOnboardingSkipper() {
-        if (!appBuildConfig.canSkipOnboarding) return
+    fun initializeOnboardingSkipper() { 
+        return
 
         // delay showing skip button until privacy config downloaded
         viewModelScope.launch {

UI changes

Screenshots

---

Note

Medium Risk
Moderate risk because it changes onboarding CTA selection/hand-off logic and introduces a new contextual dialog implementation gated by a feature flag, which could affect dialog transitions and telemetry if miswired.

Overview
Migrates the in-context onboarding End dialog to the brand-design contextual CTA path when onboardingBrandDesignUpdate is enabled, returning DaxEndBrandDesignUpdateContextualCta from CtaViewModel (both static end CTA and end-of-journey refresh).

Implements the new DaxEndBrandDesignUpdateContextualCta UI wiring (brand layout include, background, description binding, primary CTA click handler) and consolidates BrowserTabViewModel’s post-dialog OK handling so the trackers/no-trackers/main-network CTAs share a single Fire-dialog hand-off.

Adds an Android test to assert the flag-gated CTA selection and that shown/ok/dismiss pixels and “mark as read” dismissal behavior remain correct for the new End CTA.

^{Reviewed by Cursor Bugbot for commit 89562a2. Bugbot is set up for automated code reviews on this repo. Configure here.}

[mikescamell]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Onboarding Brand Design Update: Dismiss intro bubble on submit #8526
• Onboarding Brand Design Update: Update welcome screen copy #8515
• Onboarding Brand Design Update: Add Default Browser page #8514
• Onboarding Brand Design Update: Add in-context End dialog #8484 👈 (View in Graphite)
• Onboarding Brand Design Update: Add in-context Fire Button dialog + Inferno fire animation #8482
• Onboarding Brand Design Update: Add in-context No Trackers dialog #8481
• Onboarding Brand Design Update: Add in-context Main Network dialog #8480
• Onboarding Brand Design Update: Add in-context Trackers Blocked dialog #8479
• Onboarding Brand Design Update: Add in-context Site Suggestions dialog #8483
• Onboarding Brand Design Update: Add in-context SERP dialog #8439
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.