bug/campaign-history-date-time#98
Open
fivetran-catfritz wants to merge 5 commits intomainfrom
Open
Conversation
4 tasks
Contributor
fivetran-savage
left a comment
There was a problem hiding this comment.
Just a couple of suggestions before approval.
| @@ -1,3 +1,8 @@ | |||
| # dbt_google_ads v1.3.1 | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Add PR number and link.
Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
start_dateandend_datefields that occurred after March 2026 Fivetran Google Ads connector updates. The model now combines the newstart_date_timeandend_date_timetimestamp fields with existing date fields to ensure complete data. Note thatstart_dateandend_dateare date strings whilestart_date_timeandend_date_timeare timestamp strings, so you may need to apply your own datatype handling as needed for your use case.Submission Checklist
Changelog