Skip to content

bug/campaign-history-date-time#98

Open
fivetran-catfritz wants to merge 5 commits intomainfrom
bug/campaign-history-date-time
Open

bug/campaign-history-date-time#98
fivetran-catfritz wants to merge 5 commits intomainfrom
bug/campaign-history-date-time

Conversation

@fivetran-catfritz
Copy link
Copy Markdown
Contributor

@fivetran-catfritz fivetran-catfritz commented May 1, 2026

PR Overview

Package version introduced in this PR:

  • 1.3.1 (opted for patch since this is a bug fix for missing data, but open to discussion).

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Fixes null values in campaign start_date and end_date fields that occurred after March 2026 Fivetran Google Ads connector updates. The model now combines the new start_date_time and end_date_time timestamp fields with existing date fields to ensure complete data. Note that start_date and end_date are date strings while start_date_time and end_date_time are timestamp strings, so you may need to apply your own datatype handling as needed for your use case.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this May 1, 2026
@fivetran-catfritz fivetran-catfritz linked an issue May 5, 2026 that may be closed by this pull request
4 tasks
@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label May 5, 2026
Copy link
Copy Markdown
Contributor

@fivetran-savage fivetran-savage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions before approval.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
@@ -1,3 +1,8 @@
# dbt_google_ads v1.3.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add PR number and link.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>
Comment thread CHANGELOG.md
Copy link
Copy Markdown
Contributor

@fivetran-savage fivetran-savage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] start and end time no longer populated on campaign_history

2 participants