Skip to content

bug/campaign-history-date-time #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fivetran-catfritz wants to merge 5 commits into
base: main
Choose a base branch
from
Open

bug/campaign-history-date-time #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
218eb5b
bug/campaign-history-date-time
fivetran-catfritz May 1, 2026
6c42eda
changelog
fivetran-catfritz May 1, 2026
3043685
Generate dbt docs via GitHub Actions
github-actions[bot] May 5, 2026
2e1d371
Update CHANGELOG.md
fivetran-catfritz May 5, 2026
315014b
Update CHANGELOG.md
fivetran-catfritz May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_google_ads v1.3.1
Comment thread
fivetran-catfritz marked this conversation as resolved.
[PR #98](https://github.com/fivetran/dbt_google_ads/pull/98) includes the following updates:

Copy link
Copy Markdown
Contributor

@fivetran-savage fivetran-savage May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add PR number and link.

Copy link
Copy Markdown
Contributor Author

@fivetran-catfritz fivetran-catfritz May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

## Bug Fix
- Fixes null values in campaign `start_date` and `end_date` fields that occurred after [March 2026 Fivetran Google Ads connector updates](https://fivetran.com/docs/connectors/applications/google-ads/changelog). The model now combines the new `start_date_time` and `end_date_time` timestamp fields with existing date fields to ensure complete data. Note that `start_date` and `end_date` are date strings while `start_date_time` and `end_date_time` are timestamp strings, so you may need to apply your own datatype handling.

# dbt_google_ads v1.3.0

[PR #95](https://github.com/fivetran/dbt_google_ads/pull/95) includes the following updates:
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'google_ads'
version: '1.3.0'
version: '1.3.1'

config-version: 2
require-dbt-version: [">=1.3.0", "<3.0.0"]
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json
View file
Open in desktop

Large diffs are not rendered by default.

253 changes: 3 additions & 250 deletions docs/index.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'google_ads_integration_tests'
version: '1.3.0'
version: '1.3.1'

profile: 'integration_tests'
config-version: 2
Expand Down
22 changes: 11 additions & 11 deletions integration_tests/seeds/campaign_history_data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
id,updated_at,name,customer_id,advertising_channel_type,advertising_channel_subtype,start_date,end_date,serving_status,status,tracking_url_template,_fivetran_synced
9935249409,2021-06-29T17:19:05.102,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2021-08-25T20:21:09.602,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-05-31T17:55:44.964,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-06-21T03:38:52,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-06-24T05:35:31,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-07-12T06:48:40,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-01T14:21:25,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-08T16:16:48,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-12T08:15:49,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-17T12:09:49,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22,2037-12-30,SERVING,PAUSED,,2021-06-29T17:19:06.102
id,updated_at,name,customer_id,advertising_channel_type,advertising_channel_subtype,start_date_time,end_date_time,serving_status,status,tracking_url_template,_fivetran_synced
9935249409,2021-06-29T17:19:05.102,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2021-08-25T20:21:09.602,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-05-31T17:55:44.964,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-06-21T03:38:52,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-06-24T05:35:31,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-07-12T06:48:40,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-01T14:21:25,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-08T16:16:48,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-12T08:15:49,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
9935249409,2022-08-17T12:09:49,Zj9yTjsXtiWREoWWkz3kww==,2121450128,SEARCH,UNSPECIFIED,2020-04-22T00:00:00.000,2037-12-30T23:59:59.999,SERVING,PAUSED,,2021-06-29T17:19:06.102
2 changes: 2 additions & 0 deletions macros/staging/get_campaign_history_columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
{"name": "advertising_channel_type", "datatype": dbt.type_string()},
{"name": "customer_id", "datatype": dbt.type_int()},
{"name": "end_date", "datatype": dbt.type_string()},
{"name": "end_date_time", "datatype": dbt.type_timestamp()},
{"name": "id", "datatype": dbt.type_int()},
{"name": "name", "datatype": dbt.type_string()},
{"name": "serving_status", "datatype": dbt.type_string()},
{"name": "start_date", "datatype": dbt.type_string()},
{"name": "start_date_time", "datatype": dbt.type_timestamp()},
{"name": "status", "datatype": dbt.type_string()},
{"name": "tracking_url_template", "datatype": dbt.type_string()},
{"name": "updated_at", "datatype": dbt.type_timestamp()},
Expand Down
4 changes: 4 additions & 0 deletions models/staging/src_google_ads.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,12 @@ sources:
description: The advertising channel subtype that is being used by the campaign.
- name: start_date
description: The start date of the campaign.
- name: start_date_time
description: The start date and time of the campaign as a timestamp.
- name: end_date
description: The end date of the campaign.
- name: end_date_time
description: The end date and time of the campaign as a timestamp.
- name: serving_status
description: Status of the ads and how they are currently being served.
- name: status
Expand Down
4 changes: 2 additions & 2 deletions models/staging/stg_google_ads.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ models:
- name: advertising_channel_subtype
description: The advertising channel subtype that is being used by the campaign.
- name: start_date
description: The start date of the campaign.
description: The start date of the campaign. Uses start_date_time when available, falls back to start_date for backward compatibility.
- name: end_date
description: The end date of the campaign.
description: The end date of the campaign. Uses end_date_time when available, falls back to end_date for backward compatibility.
- name: serving_status
description: Status of the ads and how they are currently being served.
- name: status
Expand Down
4 changes: 2 additions & 2 deletions models/staging/stg_google_ads__campaign_history.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ final as (
customer_id as account_id,
advertising_channel_type,
advertising_channel_subtype,
start_date,
end_date,
coalesce(cast(start_date_time as {{ dbt.type_string() }}), cast(start_date as {{ dbt.type_string() }})) as start_date,
coalesce(cast(end_date_time as {{ dbt.type_string() }}), cast(end_date as {{ dbt.type_string() }})) as end_date,
serving_status,
status,
tracking_url_template,
Expand Down