Bump bitcoin-payment-instructions to bc7d03f (LNURL desc-hash relaxation)#30
Open
martinsaposnic wants to merge 1 commit into
Open
Conversation
Picks up moneydevkit/bitcoin-payment-instructions#2, which accepts LNURL-pay BOLT11 invoices that ship a plain `d` description tag instead of the LUD-06-required `h = sha256(metadata)`. Required for moneydevkit payouts to non-compliant LNURL servers (e.g. bringin.xyz lightning addresses) to succeed. Same `2025-12-ldk-node-base` branch as before; SHA bumps from 6796e87 to bc7d03f (one commit ahead).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line
revbump inCargo.toml:bitcoin-payment-instructionsfrom6796e87tobc7d03fon the same2025-12-ldk-node-basebranch.bc7d03fcarries one commit on top of6796e87: moneydevkit/bitcoin-payment-instructions#2, which accepts LNURL-pay BOLT11 invoices with a plainddescription tag instead of the LUD-06-requiredh = sha256(metadata).Motivation
Required for moneydevkit payouts to LNURL servers like
bringin.xyzto succeed. Those servers mint BOLT11 invoices withd = "Topup <N> sats"and nohtag, which upstreambitcoin-payment-instructions(correctly per LUD-06) rejects with"BOLT 11 invoice resolved via LNURL must have a matching description hash". We accept anyway to match Strike's permissive behavior.Companion PRs:
bc7d03f)Why this PR exists
Without this bump,
lightning-jsconsumers end up with two copies ofbitcoin-payment-instructionsin theircargo tree -d: one fromlightning-jsdirectly atbc7d03f, and one transitively vialdk-nodeat the old6796e87. Same crate, same v0.6.0, two compiled copies. This PR closes that gap for thelsp-0.7.0_accept-underpaying-htlcs_with_timing_logsbranch.Note:
lsp-0.7.0_socks-support(consumed bymdkd) still pins6796e87. A separate PR will need to bump that branch too if we wantmdkdto dedup as well.Test plan
cargo checkclean on this branch with the bump applied