Skip to content

Remove edpm_iscsid_image container references#1923

Draft
katarimanojk wants to merge 1 commit into
openstack-k8s-operators:mainfrom
katarimanojk:iscsid_container_cleanup
Draft

Remove edpm_iscsid_image container references#1923
katarimanojk wants to merge 1 commit into
openstack-k8s-operators:mainfrom
katarimanojk:iscsid_container_cleanup

Conversation

@katarimanojk
Copy link
Copy Markdown

The iscsid service has been moved from container to host-based deployment in edpm-ansible (PR #984). This change removes or deprecates all references to EdpmIscsidImage throughout the codebase:

  • Removed from service containerImageFields (nova, run-os)
  • Removed from inventory variable assignment
  • Deprecated API fields with comments (preserves backward compatibility)
  • Updated sample configurations with deprecation notes
  • Removed from documentation
  • Commented out build-time image variables
  • Updated tests to remove EdpmIscsidImage assertions

The EdpmIscsidImage field remains in the API types but is marked as deprecated to avoid breaking changes for existing deployments.

Related: openstack-k8s-operators/edpm-ansible#984

The iscsid service has been moved from container to host-based
deployment in edpm-ansible (PR openstack-k8s-operators#984). This change removes or
deprecates all references to EdpmIscsidImage throughout the codebase:

- Removed from service containerImageFields (nova, run-os)
- Removed from inventory variable assignment
- Deprecated API fields with comments (preserves backward compatibility)
- Updated sample configurations with deprecation notes
- Removed from documentation
- Commented out build-time image variables
- Updated tests to remove EdpmIscsidImage assertions

The EdpmIscsidImage field remains in the API types but is marked as
deprecated to avoid breaking changes for existing deployments.

Related: openstack-k8s-operators/edpm-ansible#984

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from abays and rabi May 19, 2026 10:48
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katarimanojk
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322464 bytes (315KB)
Base branch size 322464 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@katarimanojk katarimanojk marked this pull request as draft May 19, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant