Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/core/v1beta1/openstackversion_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ type ContainerTemplate struct {
DesignateProducerImage *string `json:"designateProducerImage,omitempty"`
DesignateUnboundImage *string `json:"designateUnboundImage,omitempty"`
DesignateWorkerImage *string `json:"designateWorkerImage,omitempty"`
EdpmFrrImage *string `json:"edpmFrrImage,omitempty"`
EdpmIscsidImage *string `json:"edpmIscsidImage,omitempty"`
EdpmFrrImage *string `json:"edpmFrrImage,omitempty"`
// Deprecated: EdpmIscsidImage is no longer used. iscsid now runs on the host instead of in a container.
EdpmIscsidImage *string `json:"edpmIscsidImage,omitempty"`
EdpmLogrotateCrondImage *string `json:"edpmLogrotateCrondImage,omitempty"`
EdpmMultipathdImage *string `json:"edpmMultipathdImage,omitempty"`
EdpmNeutronDhcpAgentImage *string `json:"edpmNeutronDhcpAgentImage,omitempty"`
Expand Down
14 changes: 8 additions & 6 deletions api/dataplane/v1beta1/openstackdataplanenodeset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,10 @@ var ContainerImageDefaults = openstackv1.ContainerImages{
AgentImage: getStrPtr("quay.io/openstack-k8s-operators/openstack-baremetal-operator-agent:current-podified"),
AnsibleeeImage: getStrPtr("quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest"),
ApacheImage: getStrPtr("registry.redhat.io/ubi9/httpd-24:latest"),
EdpmFrrImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-frr:current-podified"),
EdpmIscsidImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-iscsid:current-podified"),
EdpmLogrotateCrondImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-cron:current-podified"),
EdpmFrrImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-frr:current-podified"),
// Deprecated: EdpmIscsidImage is no longer used. iscsid now runs on the host instead of in a container.
EdpmIscsidImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-iscsid:current-podified"),
EdpmLogrotateCrondImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-cron:current-podified"),
EdpmNeutronDhcpAgentImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-neutron-dhcp-agent:current-podified"),
EdpmNeutronMetadataAgentImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-neutron-metadata-agent-ovn:current-podified"),
EdpmNeutronOvnAgentImage: getStrPtr("quay.io/podified-antelope-centos9/openstack-neutron-ovn-agent:current-podified"),
Expand Down Expand Up @@ -263,9 +264,10 @@ func SetupDefaults() {
AgentImage: getImageDefault("RELATED_IMAGE_AGENT_IMAGE_URL_DEFAULT", ContainerImageDefaults.AgentImage),
AnsibleeeImage: getImageDefault("RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT", ContainerImageDefaults.AnsibleeeImage),
ApacheImage: getImageDefault("RELATED_IMAGE_APACHE_IMAGE_URL_DEFAULT", ContainerImageDefaults.ApacheImage),
EdpmFrrImage: getImageDefault("RELATED_IMAGE_EDPM_FRR_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmFrrImage),
EdpmIscsidImage: getImageDefault("RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmIscsidImage),
EdpmLogrotateCrondImage: getImageDefault("RELATED_IMAGE_EDPM_LOGROTATE_CROND_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmLogrotateCrondImage),
EdpmFrrImage: getImageDefault("RELATED_IMAGE_EDPM_FRR_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmFrrImage),
// Deprecated: EdpmIscsidImage is no longer used. iscsid now runs on the host instead of in a container.
EdpmIscsidImage: getImageDefault("RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmIscsidImage),
EdpmLogrotateCrondImage: getImageDefault("RELATED_IMAGE_EDPM_LOGROTATE_CROND_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmLogrotateCrondImage),
EdpmMultipathdImage: getImageDefault("RELATED_IMAGE_EDPM_MULTIPATHD_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmMultipathdImage),
EdpmNeutronDhcpAgentImage: getImageDefault("RELATED_IMAGE_EDPM_NEUTRON_DHCP_AGENT_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmNeutronDhcpAgentImage),
EdpmNeutronMetadataAgentImage: getImageDefault("RELATED_IMAGE_EDPM_NEUTRON_METADATA_AGENT_IMAGE_URL_DEFAULT", ContainerImageDefaults.EdpmNeutronMetadataAgentImage),
Expand Down
5 changes: 3 additions & 2 deletions config/operator/default_images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ spec:
value: quay.io/podified-antelope-centos9/openstack-designate-worker:current-podified
- name: RELATED_IMAGE_EDPM_FRR_IMAGE_URL_DEFAULT
value: quay.io/podified-antelope-centos9/openstack-frr:current-podified
- name: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT
value: quay.io/podified-antelope-centos9/openstack-iscsid:current-podified
# Deprecated: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT is no longer used - iscsid now runs on the host
# - name: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT
# value: quay.io/podified-antelope-centos9/openstack-iscsid:current-podified
- name: RELATED_IMAGE_EDPM_LOGROTATE_CROND_IMAGE_URL_DEFAULT
value: quay.io/podified-antelope-centos9/openstack-cron:current-podified
- name: RELATED_IMAGE_EDPM_MULTIPATHD_IMAGE_URL_DEFAULT
Expand Down
2 changes: 1 addition & 1 deletion config/samples/dataplane/post_ceph_hci/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ data:
vars:
timesync_ntp_servers:
- hostname: clock.redhat.com
edpm_iscsid_image: '{{ registry_url }}/openstack-iscsid:{{ image_tag }}'
# edpm_iscsid_image is no longer used - iscsid now runs on the host instead of in a container
edpm_logrotate_crond_image: '{{ registry_url }}/openstack-cron:{{ image_tag }}'
edpm_network_config_hide_sensitive_logs: false
edpm_network_config_os_net_config_mappings:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/dataplane/pre_ceph_hci/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ data:
# CHANGEME -- see https://access.redhat.com/solutions/253273
# edpm_bootstrap_command: |
# subscription-manager register --username {{ subscription_manager_username }} --password {{ subscription_manager_password }}
edpm_iscsid_image: '{{ registry_url }}/openstack-iscsid:{{ image_tag }}'
# edpm_iscsid_image is no longer used - iscsid now runs on the host instead of in a container
edpm_logrotate_crond_image: '{{ registry_url }}/openstack-cron:{{ image_tag }}'
edpm_network_config_hide_sensitive_logs: false
edpm_network_config_os_net_config_mappings:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ spec:
edpmServiceType: nova
containerImageFields:
- NovaComputeImage
- EdpmIscsidImage
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ spec:
playbook: osp.edpm.run_os
containerImageFields:
- EdpmLogrotateCrondImage
- EdpmIscsidImage
edpmServiceType: run-os
2 changes: 0 additions & 2 deletions docs/assemblies/common_configurations.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ customized locations. The ansible variables used to set the locations and their
default values are:

ifeval::["{build}" != "downstream"]
edpm_iscsid_image: "quay.io/podified-antelope-centos9/openstack-iscsid
edpm_logrotate_crond_image: "quay.io/podified-antelope-centos9/openstack-cron
edpm_ovn_controller_agent_image: "quay.io/podified-antelope-centos9/openstack-ovn-controller
edpm_frr_image: "quay.io/podified-antelope-centos9/openstack-frr
Expand All @@ -104,7 +103,6 @@ ifeval::["{build}" != "downstream"]
edpm_swift_object_image: "quay.io/podified-antelope-centos9/openstack-swift-object
endif::[]
ifeval::["{build}" == "downstream"]
edpm_iscsid_image: "redhat.registry.io/rhoso-beta/openstack-iscsid-rhel9:18.0.0
edpm_logrotate_crond_image: "redhat.registry.io/rhoso-beta/openstack-cron-rhel9:18.0.0
edpm_ovn_controller_agent_image: "redhat.registry.io/rhoso-beta/openstack-ovn-controller-rhel9:18.0.0
edpm_frr_image: "redhat.registry.io/rhoso-beta/openstack-frr-rhel9:18.0.0
Expand Down
5 changes: 0 additions & 5 deletions docs/assemblies/ctlplane_resources.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2033,11 +2033,6 @@ ContainerTemplate - struct that contains container image URLs for each service i
| *string
| false

| edpmIscsidImage
|
| *string
| false

| edpmLogrotateCrondImage
|
| *string
Expand Down
2 changes: 0 additions & 2 deletions docs/assemblies/proc_creating-a-set-of-data-plane-nodes.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,6 @@ spec:
...
ansibleVars:
ifeval::["{build}" != "downstream"]
edpm_iscsid_image: "quay.io/podified-antelope-centos9/openstack-iscsid:current-podified"
edpm_logrotate_crond_image: "quay.io/podified-antelope-centos9/openstack-cron:current-podified"
edpm_ovn_controller_agent_image: "quay.io/podified-antelope-centos9/openstack-frr:current-podified"
edpm_ovn_metadata_agent_image: "quay.io/podified-antelope-centos9/openstack-neutron-metadata-agent-ovn:current-podified"
Expand All @@ -294,7 +293,6 @@ ifeval::["{build}" != "downstream"]
edpm_multipathd_image: "quay.io/podified-antelope-centos9/openstack-multipathd:current-podified"
endif::[]
ifeval::["{build}" == "downstream"]
edpm_iscsid_image: "registry.redhat.io/rhosp-dev-preview/openstack-iscsid:18.0"
edpm_logrotate_crond_image: "registry.redhat.io/rhosp-dev-preview/openstack-cron:18.0"
edpm_ovn_controller_agent_image: "registry.redhat.io/rhosp-dev-preview/openstack-frr:18.0"
edpm_ovn_metadata_agent_image: "registry.redhat.io/rhosp-dev-preview/openstack-neutron-metadata-agent-ovn:18.0"
Expand Down
3 changes: 2 additions & 1 deletion hack/export_related_images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ export RELATED_IMAGE_BARBICAN_API_IMAGE_URL_DEFAULT=quay.io/podified-antelope-ce
export RELATED_IMAGE_BARBICAN_WORKER_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-barbican-worker:current-podified
export RELATED_IMAGE_BARBICAN_KEYSTONE_LISTENER_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-barbican-keystone-listener:current-podified
export RELATED_IMAGE_EDPM_FRR_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-frr:current-podified
export RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-iscsid:current-podified
# Deprecated: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT is no longer used - iscsid now runs on the host
# export RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-iscsid:current-podified
export RELATED_IMAGE_EDPM_LOGROTATE_CROND_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-cron:current-podified
export RELATED_IMAGE_EDPM_MULTIPATHD_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-multipathd:current-podified
export RELATED_IMAGE_EDPM_NEUTRON_DHCP_AGENT_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-neutron-dhcp-agent:current-podified
Expand Down
4 changes: 1 addition & 3 deletions internal/dataplane/inventory.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,7 @@ func resolveGroupAnsibleVars(template *dataplanev1.NodeTemplate, group *ansible.
if template.Ansible.AnsibleVars["edpm_frr_image"] == nil {
group.Vars["edpm_frr_image"] = containerImages.EdpmFrrImage
}
if template.Ansible.AnsibleVars["edpm_iscsid_image"] == nil {
group.Vars["edpm_iscsid_image"] = containerImages.EdpmIscsidImage
}
// edpm_iscsid_image is no longer used - iscsid now runs on the host instead of in a container
if template.Ansible.AnsibleVars["edpm_logrotate_crond_image"] == nil {
group.Vars["edpm_logrotate_crond_image"] = containerImages.EdpmLogrotateCrondImage
}
Expand Down
2 changes: 2 additions & 0 deletions internal/dataplane/util/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func GetContainerImages(version *openstackv1.OpenStackVersion) openstackv1.Conta
containerImages.CeilometerComputeImage = version.Status.ContainerImages.CeilometerComputeImage
containerImages.CeilometerIpmiImage = version.Status.ContainerImages.CeilometerIpmiImage
containerImages.EdpmFrrImage = version.Status.ContainerImages.EdpmFrrImage
// Deprecated: EdpmIscsidImage is no longer used. iscsid now runs on the host instead of in a container.
containerImages.EdpmIscsidImage = version.Status.ContainerImages.EdpmIscsidImage
containerImages.EdpmLogrotateCrondImage = version.Status.ContainerImages.EdpmLogrotateCrondImage
containerImages.EdpmMultipathdImage = version.Status.ContainerImages.EdpmMultipathdImage
Expand All @@ -90,6 +91,7 @@ func GetContainerImages(version *openstackv1.OpenStackVersion) openstackv1.Conta
containerImages.CeilometerComputeImage = dataplanev1.ContainerImages.CeilometerComputeImage
containerImages.CeilometerIpmiImage = dataplanev1.ContainerImages.CeilometerIpmiImage
containerImages.EdpmFrrImage = dataplanev1.ContainerImages.EdpmFrrImage
// Deprecated: EdpmIscsidImage is no longer used. iscsid now runs on the host instead of in a container.
containerImages.EdpmIscsidImage = dataplanev1.ContainerImages.EdpmIscsidImage
containerImages.EdpmLogrotateCrondImage = dataplanev1.ContainerImages.EdpmLogrotateCrondImage
containerImages.EdpmMultipathdImage = dataplanev1.ContainerImages.EdpmMultipathdImage
Expand Down
7 changes: 4 additions & 3 deletions internal/openstack/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,10 @@ func GetContainerImages(defaults *corev1beta1.ContainerDefaults, instance corev1
DesignateProducerImage: getImg(instance.Spec.CustomContainerImages.DesignateProducerImage, defaults.DesignateProducerImage),
DesignateUnboundImage: getImg(instance.Spec.CustomContainerImages.DesignateUnboundImage, defaults.DesignateUnboundImage),
DesignateWorkerImage: getImg(instance.Spec.CustomContainerImages.DesignateWorkerImage, defaults.DesignateWorkerImage),
EdpmFrrImage: getImg(instance.Spec.CustomContainerImages.EdpmFrrImage, defaults.EdpmFrrImage),
EdpmIscsidImage: getImg(instance.Spec.CustomContainerImages.EdpmIscsidImage, defaults.EdpmIscsidImage),
EdpmLogrotateCrondImage: getImg(instance.Spec.CustomContainerImages.EdpmLogrotateCrondImage, defaults.EdpmLogrotateCrondImage),
EdpmFrrImage: getImg(instance.Spec.CustomContainerImages.EdpmFrrImage, defaults.EdpmFrrImage),
// Deprecated: EdpmIscsidImage is no longer used. iscsid now runs on the host instead of in a container.
EdpmIscsidImage: getImg(instance.Spec.CustomContainerImages.EdpmIscsidImage, defaults.EdpmIscsidImage),
EdpmLogrotateCrondImage: getImg(instance.Spec.CustomContainerImages.EdpmLogrotateCrondImage, defaults.EdpmLogrotateCrondImage),
EdpmMultipathdImage: getImg(instance.Spec.CustomContainerImages.EdpmMultipathdImage, defaults.EdpmMultipathdImage),
EdpmNeutronDhcpAgentImage: getImg(instance.Spec.CustomContainerImages.EdpmNeutronDhcpAgentImage, defaults.EdpmNeutronDhcpAgentImage),
EdpmNeutronMetadataAgentImage: getImg(instance.Spec.CustomContainerImages.EdpmNeutronMetadataAgentImage, defaults.EdpmNeutronMetadataAgentImage),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ var _ = Describe("OpenStackOperator controller", func() {
g.Expect(version.Status.ContainerImages.DesignateUnboundImage).ShouldNot(BeNil())
g.Expect(version.Status.ContainerImages.DesignateWorkerImage).ShouldNot(BeNil())
g.Expect(version.Status.ContainerImages.EdpmFrrImage).ShouldNot(BeNil())
g.Expect(version.Status.ContainerImages.EdpmIscsidImage).ShouldNot(BeNil())
// EdpmIscsidImage is deprecated - iscsid now runs on the host instead of in a container
g.Expect(version.Status.ContainerImages.EdpmLogrotateCrondImage).ShouldNot(BeNil())
g.Expect(version.Status.ContainerImages.EdpmMultipathdImage).ShouldNot(BeNil())
g.Expect(version.Status.ContainerImages.EdpmNeutronMetadataAgentImage).ShouldNot(BeNil())
Expand Down
Loading