Skip to content

chore(triggers): deprecate trigger-save subblock#4107

Open
waleedlatif1 wants to merge 2 commits intostagingfrom
waleedlatif1/deprecate-trigger-save
Open

chore(triggers): deprecate trigger-save subblock#4107
waleedlatif1 wants to merge 2 commits intostagingfrom
waleedlatif1/deprecate-trigger-save

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Remove the defunct triggerSave subblock from all 102 trigger definitions across every provider
  • Remove trigger-save from SubBlockType union, SYSTEM_SUBBLOCK_IDS, tool params, and command templates
  • Retain the backwards-compat filter in getTrigger() to safely handle any legacy stored data

Type of Change

  • Refactor / cleanup (no behavior change)

Testing

  • All 76 block tests pass
  • tsc --noEmit passes with zero errors
  • Lint passes clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Remove the defunct triggerSave subblock from all 102 trigger definitions,
the SubBlockType union, SYSTEM_SUBBLOCK_IDS, tool params, and command
templates. Retain the backwards-compat filter in getTrigger() for any
legacy stored data.
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 11, 2026 4:01pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 11, 2026

PR Summary

Low Risk
Primarily a mechanical removal of a UI-only subblock across trigger definitions and related type lists; main risk is small UI/regression potential where legacy trigger configs might still reference triggerSave, mitigated by filtering in getTrigger().

Overview
Removes the legacy triggerSave/trigger-save subblock from trigger definitions across providers and updates supporting lists/types so it’s no longer considered a valid SubBlockType or system subblock.

Keeps backward compatibility by filtering any persisted triggerSave subblocks out of getTrigger() results, and updates tests/templates and tooling logic to stop expecting or excluding trigger-save.

Reviewed by Cursor Bugbot for commit 7349b13. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7349b13. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant