Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .claude/commands/add-trigger.md
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,6 @@ export const {service}PollingTrigger: TriggerConfig = {
subBlocks: [
{ id: 'triggerCredentials', type: 'oauth-input', title: 'Credentials', serviceId: '{service}', requiredScopes: [], required: true, mode: 'trigger', supportsCredentialSets: true },
// ... service-specific config fields (dropdowns, inputs, switches) ...
{ id: 'triggerSave', type: 'trigger-save', title: '', hideFromPreview: true, mode: 'trigger', triggerId: '{service}_poller' },
{ id: 'triggerInstructions', type: 'text', title: 'Setup Instructions', hideFromPreview: true, mode: 'trigger', defaultValue: '...' },
],

Expand Down Expand Up @@ -486,7 +485,6 @@ Add to `helm/sim/values.yaml` under the existing polling cron jobs:
- [ ] Handler implements `PollingProviderHandler` at `lib/webhooks/polling/{service}.ts`
- [ ] Trigger config has `polling: true` and defines subBlocks manually (no `buildTriggerSubBlocks`)
- [ ] Provider string matches across: trigger config, handler, `POLLING_PROVIDERS`, polling registry
- [ ] `triggerSave` subBlock `triggerId` matches trigger config `id`
- [ ] First poll seeds state and emits nothing
- [ ] Added provider to `POLLING_PROVIDERS` in `triggers/constants.ts`
- [ ] Added handler to `POLLING_HANDLERS` in `lib/webhooks/polling/registry.ts`
Expand Down
2 changes: 0 additions & 2 deletions .cursor/commands/add-trigger.md
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,6 @@ export const {service}PollingTrigger: TriggerConfig = {
subBlocks: [
{ id: 'triggerCredentials', type: 'oauth-input', title: 'Credentials', serviceId: '{service}', requiredScopes: [], required: true, mode: 'trigger', supportsCredentialSets: true },
// ... service-specific config fields (dropdowns, inputs, switches) ...
{ id: 'triggerSave', type: 'trigger-save', title: '', hideFromPreview: true, mode: 'trigger', triggerId: '{service}_poller' },
{ id: 'triggerInstructions', type: 'text', title: 'Setup Instructions', hideFromPreview: true, mode: 'trigger', defaultValue: '...' },
],

Expand Down Expand Up @@ -481,7 +480,6 @@ Add to `helm/sim/values.yaml` under the existing polling cron jobs:
- [ ] Handler implements `PollingProviderHandler` at `lib/webhooks/polling/{service}.ts`
- [ ] Trigger config has `polling: true` and defines subBlocks manually (no `buildTriggerSubBlocks`)
- [ ] Provider string matches across: trigger config, handler, `POLLING_PROVIDERS`, polling registry
- [ ] `triggerSave` subBlock `triggerId` matches trigger config `id`
- [ ] First poll seeds state and emits nothing
- [ ] Added provider to `POLLING_PROVIDERS` in `triggers/constants.ts`
- [ ] Added handler to `POLLING_HANDLERS` in `lib/webhooks/polling/registry.ts`
Expand Down
1 change: 0 additions & 1 deletion apps/sim/blocks/blocks.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,6 @@ describe.concurrent('Blocks Module', () => {
'mcp-dynamic-args',
'input-format',
'response-format',
'trigger-save',
'file-upload',
'input-mapping',
'variables-input',
Expand Down
1 change: 0 additions & 1 deletion apps/sim/blocks/blocks/linear.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2561,7 +2561,6 @@ export const LinearV2Block: BlockConfig<LinearResponse> = {
(sb) =>
!sb.id?.startsWith('webhookUrlDisplay') &&
!sb.id?.startsWith('webhookSecret') &&
!sb.id?.startsWith('triggerSave') &&
!sb.id?.startsWith('triggerInstructions') &&
!sb.id?.startsWith('selectedTriggerId')
),
Expand Down
6 changes: 0 additions & 6 deletions apps/sim/blocks/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,6 @@ export type SubBlockType =
| 'response-format' // Response structure format
| 'filter-builder' // Filter conditions builder
| 'sort-builder' // Sort conditions builder
/**
* @deprecated Legacy trigger save subblock type.
*/
| 'trigger-save' // Trigger save button with validation
| 'file-upload' // File uploader
| 'input-mapping' // Map parent variables to child workflow input schema
| 'variables-input' // Variable assignments for updating workflow variables
Expand Down Expand Up @@ -414,8 +410,6 @@ export interface SubBlockConfig {
dependsOn?: string[] | { all?: string[]; any?: string[] }
// Copyable-text specific: Use webhook URL from webhook management hook
useWebhookUrl?: boolean
// Trigger-save specific: The trigger ID for validation and saving
triggerId?: string
// Dropdown/Combobox: Function to fetch options dynamically
// Works with both 'dropdown' (select-only) and 'combobox' (editable with expression support)
fetchOptions?: (blockId: string) => Promise<Array<{ label: string; id: string }>>
Expand Down
1 change: 0 additions & 1 deletion apps/sim/tools/params.ts
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,6 @@ const EXCLUDED_SUBBLOCK_TYPES = new Set([
'eval-input',
'webhook-config',
'schedule-info',
'trigger-save',
'input-format',
'response-format',
'mcp-server-selector',
Expand Down
8 changes: 0 additions & 8 deletions apps/sim/triggers/airtable/webhook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ export const airtableWebhookTrigger: TriggerConfig = {
defaultValue: false,
mode: 'trigger',
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'airtable_webhook',
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
7 changes: 0 additions & 7 deletions apps/sim/triggers/attio/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,6 @@ export function buildAttioTriggerSubBlocks(triggerId: string): SubBlockConfig[]
required: true,
condition: { field: 'selectedTriggerId', value: triggerId },
},
{
id: 'triggerSave',
title: 'Save',
type: 'trigger-save',
mode: 'trigger',
condition: { field: 'selectedTriggerId', value: triggerId },
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/calendly/invitee_canceled.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@ export const calendlyInviteeCanceledTrigger: TriggerConfig = {
value: 'calendly_invitee_canceled',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'calendly_invitee_canceled',
condition: {
field: 'selectedTriggerId',
value: 'calendly_invitee_canceled',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/calendly/invitee_created.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,6 @@ export const calendlyInviteeCreatedTrigger: TriggerConfig = {
value: 'calendly_invitee_created',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'calendly_invitee_created',
condition: {
field: 'selectedTriggerId',
value: 'calendly_invitee_created',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/calendly/routing_form_submitted.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@ export const calendlyRoutingFormSubmittedTrigger: TriggerConfig = {
value: 'calendly_routing_form_submitted',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'calendly_routing_form_submitted',
condition: {
field: 'selectedTriggerId',
value: 'calendly_routing_form_submitted',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/calendly/webhook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,6 @@ export const calendlyWebhookTrigger: TriggerConfig = {
value: 'calendly_webhook',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'calendly_webhook',
condition: {
field: 'selectedTriggerId',
value: 'calendly_webhook',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/circleback/meeting_completed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,6 @@ export const circlebackMeetingCompletedTrigger: TriggerConfig = {
value: 'circleback_meeting_completed',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'circleback_meeting_completed',
condition: {
field: 'selectedTriggerId',
value: 'circleback_meeting_completed',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/circleback/meeting_notes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,6 @@ export const circlebackMeetingNotesTrigger: TriggerConfig = {
value: 'circleback_meeting_notes',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'circleback_meeting_notes',
condition: {
field: 'selectedTriggerId',
value: 'circleback_meeting_notes',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/circleback/webhook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,6 @@ export const circlebackWebhookTrigger: TriggerConfig = {
value: 'circleback_webhook',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'circleback_webhook',
condition: {
field: 'selectedTriggerId',
value: 'circleback_webhook',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
1 change: 0 additions & 1 deletion apps/sim/triggers/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export const SYSTEM_SUBBLOCK_IDS: string[] = [
'samplePayload', // Example payload display
'setupScript', // Setup script code (e.g., Apps Script)
'scheduleInfo', // Schedule status display (next run, last run)
'triggerSave', // UI-only save button — stores no config data
]

/**
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/fathom/new_meeting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,6 @@ export const fathomNewMeetingTrigger: TriggerConfig = {
value: 'fathom_new_meeting',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'fathom_new_meeting',
condition: {
field: 'selectedTriggerId',
value: 'fathom_new_meeting',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/fathom/webhook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,6 @@ export const fathomWebhookTrigger: TriggerConfig = {
value: 'fathom_webhook',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'fathom_webhook',
condition: {
field: 'selectedTriggerId',
value: 'fathom_webhook',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
8 changes: 0 additions & 8 deletions apps/sim/triggers/fireflies/transcription_complete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ export const firefliesTranscriptionCompleteTrigger: TriggerConfig = {
required: false,
mode: 'trigger',
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'fireflies_transcription_complete',
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
8 changes: 0 additions & 8 deletions apps/sim/triggers/generic/webhook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ export const genericWebhookTrigger: TriggerConfig = {
'Define the expected JSON input schema for this webhook (optional). Use type "file[]" for file uploads.',
mode: 'trigger',
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'generic_webhook',
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/github/issue_closed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,6 @@ export const githubIssueClosedTrigger: TriggerConfig = {
value: 'github_issue_closed',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'github_issue_closed',
condition: {
field: 'selectedTriggerId',
value: 'github_issue_closed',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/github/issue_comment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,6 @@ export const githubIssueCommentTrigger: TriggerConfig = {
value: 'github_issue_comment',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'github_issue_comment',
condition: {
field: 'selectedTriggerId',
value: 'github_issue_comment',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/github/issue_opened.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,6 @@ export const githubIssueOpenedTrigger: TriggerConfig = {
value: 'github_issue_opened',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'github_issue_opened',
condition: {
field: 'selectedTriggerId',
value: 'github_issue_opened',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
12 changes: 0 additions & 12 deletions apps/sim/triggers/github/pr_closed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,6 @@ export const githubPRClosedTrigger: TriggerConfig = {
value: 'github_pr_closed',
},
},
{
id: 'triggerSave',
title: '',
type: 'trigger-save',
hideFromPreview: true,
mode: 'trigger',
triggerId: 'github_pr_closed',
condition: {
field: 'selectedTriggerId',
value: 'github_pr_closed',
},
},
{
id: 'triggerInstructions',
title: 'Setup Instructions',
Expand Down
Loading
Loading