Dedup some httpd related templates#694
Merged
Merged
Conversation
This was referenced May 14, 2026
|
I think this patch and how it's consumed in the following is a good de-duplication |
stuggi
reviewed
May 15, 2026
Contributor
Author
Contributor
|
@fmount I actually looked last week and forgot to say... /lgtm |
stuggi
reviewed
May 18, 2026
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Add a CommonTemplates []string field to the Template struct that allows service operators to specify which embedded common templates to include. This avoids injecting common templates (e.g. ssl.conf) into components that don't need them (e.g. cinder-scheduler, cinder-volume). Signed-off-by: Francesco Pantano <fpantano@redhat.com>
This was referenced May 18, 2026
Merged
Open
Merged
Merged
This was referenced May 18, 2026
Merged
Merged
Merged
Merged
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ssl.confhttpdconfiguration is duplicated across service operators. Any TLS policy change (cipher suites,protocol versions) requires coordinated patches across all repositories.
This patch embeds
ssl.confinlib-commonvia//go:embedand exposes aGetCommonTemplates()function that renders the embedded templates and returns the rendered content.Service operators can consume this before rendering their config files.
This approach requires no changes in the existing functions/structs and no new abstractions.
Jira: OSPRH-30239